Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: glee authentication using auth directory #473

Closed
wants to merge 55 commits into from
Closed

feat: glee authentication using auth directory #473

wants to merge 55 commits into from

Conversation

oviecodes
Copy link
Contributor

Description
This PR continues the discussion on the glee authentication issue #377 , it continues the discussion about glee authentication, from #460 .

Following the idea from @Souvikns to use a separate directory for authentication. Each file in this directory can hold both server and client authentication logic.

/** auth/serverName.ts **/

export function serverAuth({headers, done}) {
  // write logic for authentication 
  done()
}

export function clientAuth() {
  return {
    username: '',
    password: ''
  }
}

Steps to test run authentication

  • In the glee root directory, cd examples/anime-http/server,
  • The server directory, contains an auth directory that holds a trendingAnimeServer.ts file. The file contains some logic you can edit how you like but it must export the same functions as the code above
  • npm run dev to start the server in dev mode
  • The same logic applies to the client directory, cd examples/anime-http/server
  • Then look for auth/trendingAnime.js update accordingly then start the server.

Related issue(s)
Resolves #377

@Souvikns @KhudaDad414

oviecodes added 30 commits March 14, 2023 00:19
@oviecodes
refactor mqtt _connect() function
bf52926
@oviecodes
refactor mqtt _connect() function
e127849
@oviecodes
refactor mqtt _connect() function
4165e63
@oviecodes
revert to master
8a7bce3
@oviecodes
Merge branch 'master' of https://github.com/asyncapi/glee
9c4a557
@oviecodes
update lockfileVersion to 2
a3f9cd3
@oviecodes
update package.json
6504e2b
@oviecodes
Merge branch 'master' of https://github.com/asyncapi/glee
2d9f14e
@oviecodes
Merge branch 'master' of https://github.com/asyncapi/glee
6ae5f42
@oviecodes
update repo
919edd9
@oviecodes
fix
8a39e27
@oviecodes
working on glee auth
09a4b2c
@oviecodes
running auth files
1add038
@oviecodes
working on authentication
814399b
@oviecodes
auth event
fa406db
@oviecodes
update
7a2eca1
@oviecodes
update
a811c37
@oviecodes
add file checks
1881d55
@oviecodes
lifecycle authentication
f2c27ca
@oviecodes
resolve adapter conflicts
ae6b460
@oviecodes
resolve glee conflicts
9480c9e
@oviecodes
lint:fix
964522e
@oviecodes
Merge branch 'master' of https://github.com/asyncapi/glee
4b7863e 
glee authentication
@oviecodes
merged master
d85622a
@oviecodes
fixing conflicts
5f0c8b2
@oviecodes
update
9570dfb
@oviecodes
update
21d6475
@oviecodes
fix docs test
3838596
@oviecodes
http auth with lifecycle
2c73e20
@oviecodes
http auth
cb5ca48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@oviecodes oviecodes closed this Jul 9, 2023
@oviecodes oviecodes deleted the v2GleeAuth branch July 10, 2023 13:43
@coveralls
Copy link

coveralls commented Dec 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 5501228410

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 8 (37.5%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 59.437%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/adapter.ts 3 4 75.0%
src/lib/configs.ts 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib/configs.ts 2 16.5%
Totals Coverage Status
Change from base Build 5463620227: -1.1%
Covered Lines: 332
Relevant Lines: 469
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns will be requested when the pull request is marked ready for review Souvikns is a code owner

@KhudaDad414 KhudaDad414 Awaiting requested review from KhudaDad414 KhudaDad414 will be requested when the pull request is marked ready for review KhudaDad414 is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve will be requested when the pull request is marked ready for review asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oviecodes @coveralls